Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add tests for the Notice component. #3583

Merged
merged 2 commits into from Nov 21, 2017

Conversation

Projects
None yet
2 participants
Contributor

hideokamoto commented Nov 21, 2017

Description

Related to progress on the issue -> Unit Testing Components #641

Added some unit test scripts for Notice component.

How Has This Been Tested?

Run unit test command.

$ npm test
...
 PASS  components/notice/test/index.js
  Notice
    ✓ should has valid class (12ms)
    ✓ should not has is-dismissible class when isDismissible prop is false (2ms)
...

Test Suites: 1 skipped, 91 passed, 91 of 92 total
Tests:       38 skipped, 892 passed, 930 total
Snapshots:   7 passed, 7 total
Time:        15.262s
Ran all test suites.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

codecov bot commented Nov 21, 2017

Codecov Report

Merging #3583 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3583      +/-   ##
==========================================
+ Coverage   35.29%   35.32%   +0.02%     
==========================================
  Files         267      267              
  Lines        6744     6744              
  Branches     1221     1221              
==========================================
+ Hits         2380     2382       +2     
+ Misses       3687     3685       -2     
  Partials      677      677
Impacted Files Coverage Δ
components/notice/index.js 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc7b8c...7dd3190. Read the comment docs.

Member

gziolo commented Nov 21, 2017

@hideokamoto good job, this is ready to merge 🚢

@gziolo gziolo merged commit aa4ab76 into WordPress:master Nov 21, 2017

2 checks passed

codecov/project 35.32% (+0.02%) compared to 7cc7b8c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hideokamoto hideokamoto deleted the hideokamoto:add/test/notice/index branch Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment