WordPress.org

Make WordPress Core

Opened 13 months ago

Last modified 3 months ago

#42808 new defect (bug)

Remove old style PHPCS ignore comments

Reported by: netweb Owned by:
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

Currently, there are 4 files in /tests that use the PHPCS 2.x @codingStandardsIgnore* ignore comment syntax

These should be updated to the new ​PHPCS 3.2 syntax or removed if no longer required.

Attachments (1)

42808.diff​ (3.0 KB) - added by netweb 13 months ago.

Download all attachments as: .zip

Change History (6)

@netweb
13 months ago

#1 @netweb
13 months ago

  • Keywords has-patch commit added

In 42808.diff​:

Coding Standards:

  • Remove legacy PHPCS 2.x @codingStandardsIgnore* ignore comments from tests/phpunit/tests/customize
  • Update code to meet current WPCS standards (Generic.Formatting.MultipleStatementAlignment.NotSameWarning)

#2 @jrf
13 months ago

👍

#3 @netweb
13 months ago

  • Focuses coding-standards added
  • Keywords coding-standards removed

#4 @GaryJ
13 months ago

Looks good.

#5 @jorbin
3 months ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.