/gutenberg

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Docs: some design and presentation tweaks. #2657

Merged
merged 3 commits into from Sep 4, 2017
+68 −32

Conversation

Reviewers

@youknowriad youknowriad

Assignees
No one assigned
Labels
Documentation [Status] In Progress
Projects
None yet
Milestone
No milestone
2 participants
@mtias @youknowriad
@mtias
Contributor

mtias commented Sep 4, 2017

image

  • Add links to download plugin and the github repository.
  • Show permalinks on hover and remove opacity.
  • Explore showing Type when describing API properties.

mtias added some commits Sep 4, 2017

@mtias mtias Link to "Attribute Sources" and show "Type" (experiment). 6e9b403
@mtias mtias Add link to plugin and github repo; show heading permalinks on hover.

All checks have passed

3 successful checks
@codecov
codecov/project — 31.35% (-0.03%) compared to 51c2765
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
37ec3c7

@mtias mtias added Documentation [Status] In Progress labels Sep 4, 2017

@codecov

codecov bot commented Sep 4, 2017 • edited

Codecov Report

Merging #2657 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2657      +/-   ##
==========================================
- Coverage   31.38%   31.35%   -0.03%     
==========================================
  Files         177      177              
  Lines        5413     5453      +40     
  Branches      949      964      +15     
==========================================
+ Hits         1699     1710      +11     
- Misses       3139     3156      +17     
- Partials      575      587      +12
Impacted Files Coverage Δ
components/drop-zone/provider.js 1.98% <0%> (+0.64%) ⬆️
blocks/editable/index.js 12.3% <0%> (+1.77%) ⬆️
blocks/library/button/index.js 28.57% <0%> (+1.9%) ⬆️
components/button/index.js 92.85% <0%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c2765...fb7228d. Read the comment docs.
docutron/src/styles/main.css
+.content-area h4,
+.content-area h5 {
+ position: relative;
+ border-bottom: 1px solid #EDF3F1;
@youknowriad

youknowriad Sep 4, 2017

Collaborator

I personally don't like this border, I think we should drop it. Feel free to ignore, it's just a personal design opinion.

@mtias

mtias Sep 4, 2017

Contributor

Yes, I might remove.

@mtias mtias Remove border from headings.

All checks have failed

2 errored checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push — The Travis CI build could not complete due to an error
Details
fb7228d

@mtias mtias merged commit f445861 into master Sep 4, 2017
0 of 2 checks passed

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@mtias mtias deleted the update/docs-design-tweaks branch Sep 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment