Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Registration: Rename default block handlers as reflecting name #2627
+16
−16
Conversation
aduth
added
the
Block API
label
Aug 31, 2017
codecov
bot
commented
Aug 31, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #2627 +/- ##
=======================================
Coverage 31.42% 31.42%
=======================================
Files 177 177
Lines 5407 5407
Branches 946 946
=======================================
Hits 1699 1699
Misses 3135 3135
Partials 573 573
Continue to review full report at Codecov.
|
|
Makes sense. |
aduth
merged commit 6e663a4
into
master
Sep 1, 2017
aduth
deleted the
update/default-block-name branch
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
aduth commentedAug 31, 2017
This pull request seeks to rename default block handler functions to better reflect that they operate on a block name, not a block instance, type, or otherwise. This brings default block API handlers in line with unknown type handlers, which were similarly renamed in bc4d6cd. I originally planned to include these changes in a related set of changes, but since it touched a handful of files, I felt it better to create a smaller, separate pull request.
Testing instructions:
Verify there is no regressions in the behavior of the default block (paragraph).