/gutenberg

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Editable: Fix Placeholder styling #2626

Merged
merged 1 commit into from Sep 4, 2017
+1 −1

Conversation

Reviewers

@aduth aduth

@iseulde iseulde

Assignees

@youknowriad youknowriad

Labels
[Component] Editable [Type] Bug
Projects
None yet
Milestone
No milestone
2 participants
@youknowriad @aduth
@youknowriad
Collaborator

youknowriad commented Aug 31, 2017

On an empty paragraph block with a background color, a padding was applied using an extra className. But these extra classNames were not applied to the placeholder, which caused the placeholder to be incorrectly styled.

Testing instructions

  • Create a paragraph block
  • Apply a background color
  • Unselect the block
  • The placeholder should be shown properly.
@youknowriad youknowriad Editable: Fix Placeholder styling

All checks have passed

3 successful checks
@codecov
codecov/project — 31.42% remains the same compared to e76faa6
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
4dec2de

@youknowriad youknowriad added the [Type] Bug label Aug 31, 2017

@youknowriad youknowriad self-assigned this Aug 31, 2017

@youknowriad youknowriad requested review from aduth and iseulde Aug 31, 2017

@youknowriad youknowriad added the [Component] Editable label Aug 31, 2017

@aduth

aduth approved these changes Sep 1, 2017
View changes

@youknowriad youknowriad merged commit de53baf into master Sep 4, 2017
3 checks passed

3 checks passed

codecov/project 31.42% remains the same compared to e76faa6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/paragraph-with-background-placeholder branch Sep 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment