/gutenberg

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Chrome: Fix adding new categories and terms #2606

Merged
merged 1 commit into from Aug 30, 2017
+2 −2

Conversation

Reviewers

@aduth aduth

@afercia afercia

Assignees

@youknowriad youknowriad

Labels
[Type] Bug
Projects
None yet
Milestone
No milestone
2 participants
@youknowriad @aduth
@youknowriad
Collaborator

youknowriad commented Aug 30, 2017

closes #2582

Not sure where this regressed, but this PR fixes the form and also moves the newly inserted term to the top.

Testing instructions

  • Try creating a new category
  • It should be added at the top of the list and selected automatically
@youknowriad youknowriad Chrome: Fix adding new categories and terms

All checks have passed

3 successful checks
@codecov
codecov/project — 31.49% remains the same compared to 71eb775
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
2c516c3

@youknowriad youknowriad self-assigned this Aug 30, 2017

@youknowriad youknowriad requested a review from afercia Aug 30, 2017

@youknowriad youknowriad added the [Type] Bug label Aug 30, 2017

@codecov

codecov bot commented Aug 30, 2017 • edited

Codecov Report

Merging #2606 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2606   +/-   ##
=======================================
  Coverage   31.49%   31.49%           
=======================================
  Files         177      177           
  Lines        5398     5398           
  Branches      943      943           
=======================================
  Hits         1700     1700           
  Misses       3128     3128           
  Partials      570      570
Impacted Files Coverage Δ
...ebar/post-taxonomies/hierarchical-term-selector.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71eb775...2c516c3. Read the comment docs.

@youknowriad youknowriad merged commit 32647cd into master Aug 30, 2017
3 checks passed

3 checks passed

codecov/project 31.49% remains the same compared to 71eb775
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/adding-categories branch Aug 30, 2017

@afercia afercia referenced this pull request Aug 30, 2017

Open

Categories default order looks wrong #2607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment