Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Editor: Fix resetting the drop-zone states after dropping a file #2604
Conversation
youknowriad
added
the
[Type] Bug
label
Aug 30, 2017
youknowriad
self-assigned this
Aug 30, 2017
youknowriad
requested review from mapk and aduth
Aug 30, 2017
| @@ -68,7 +68,7 @@ class DropZoneProvider extends Component { | ||
| } ); | ||
| this.dropzones.forEach( ( { updateState } ) => { | ||
| - updateState( { isDraggingOverDocument, isDraggingOverElement: false, position: null } ); | ||
| + updateState( { isDraggingOverDocument: false, isDraggingOverElement: false, position: null } ); |
youknowriad
Sep 1, 2017
•
Collaborator
we definitely need prettier 
one hour dev time gained per day :)
aduth
Sep 1, 2017
Member
object-curly-newline has options for configuring number of properties before newlines are required, and includes a fixer!
youknowriad
Sep 1, 2017
Collaborator
Do you use the auto-fixer on IDE save? I never saw ESlint used for this, but yeah could be a good alternative for now
I'm using prettier "auto-save format" in other projects and it's really a huge gain.
aduth
Sep 1, 2017
Member
I don't personally, but a cursory search reveals this one for Sublime Text:
youknowriad
Sep 4, 2017
Collaborator
I found a similar config in VS Core, I'll be trying it for some days. I'm not adding the rule right now, but we should consider it in a separate PR.
codecov
bot
commented
Sep 4, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #2604 +/- ##
==========================================
+ Coverage 31.38% 31.71% +0.32%
==========================================
Files 177 177
Lines 5413 5811 +398
Branches 949 1065 +116
==========================================
+ Hits 1699 1843 +144
- Misses 3139 3309 +170
- Partials 575 659 +84
Continue to review full report at Codecov.
|
youknowriad commentedAug 30, 2017
closes #2597
The dropzone classes were not being cleaned on drop which causes the dropzone to appear over the controls.
Testings instructions