Enabled ESLint and JSCS in Hound #19482
+9
−0
3 participants
|
ameya-pandilwar |
All checks have passed
hound
— No violations found. Woof!
|
f24a018
|
git rebase -i origin/v4-dev
Assuming you have set up upstream right.
@cvrebert: If we have the checks in hound, shouldn't we stop checking those in Travis? It doesn't take long, sure, but it's just duplicate tasks.
Meh. Hound's support for ESLint & JSCS is still in beta. And what if Hound got shut down or became flaky?
(My feelings aren't strong, but anyway that's my 2¢.)
@ameya-pandilwar Merged as 122d9e5. Thanks!
Also, for future reference, utilizing https://help.github.com/articles/closing-issues-via-commit-messages/ in commit messages is preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Fix for #19114
Closes #19299