Adding subresource hashes to CDN links. #17729

Closed
wants to merge 1 commit into from

3 participants

@chris-barry

In Firefox 43 and Chrome 45 there will be support for Subresource Integrity (SRI). More information here: https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity

@chris-barry chris-barry Adding subresource hashes to CDN links.
In Firefox 43 and Chrome 45 there will be support for Subresource
Iintegrity (SRI). More information here:
https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity
ba6155c
@cvrebert
Bootstrap member

This would also need a port for the v4-dev branch.

@cvrebert cvrebert commented on the diff Sep 29, 2015
_config.yml
@@ -28,5 +28,8 @@ expo: http://expo.getbootstrap.com
cdn:
css: https://maxcdn.bootstrapcdn.com/bootstrap/3.3.5/css/bootstrap.min.css
+ css_hash: sha384-pdapHxIh7EYuwy6K7iE41uXVxGCXY0sAjBzaElYGJUrzwodck3Lx6IE2lA0rFREo
@cvrebert
Bootstrap member
cvrebert added a note Sep 29, 2015

Should probably include a comment here saying how to generate the hash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@XhmikosR
Bootstrap member
XhmikosR commented Oct 1, 2015

Shouldn't this be applied for jQuery loaded from Google's CDN?

@chris-barry
@cvrebert cvrebert added this to the v3.3.6 milestone Oct 24, 2015
@cvrebert cvrebert added a commit that closed this pull request Oct 24, 2015
@chris-barry chris-barry Adding subresource hashes to CDN links.
In Firefox 43 and Chrome 45 there will be support for Subresource
Iintegrity (SRI). More information here:
https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity

Closes #17729 by merging a tweaked version of it.
9aeec56
@cvrebert cvrebert closed this in 9aeec56 Oct 24, 2015
@cvrebert
Bootstrap member

Merged. Thanks!
Also updated the relevant page of the hosted docs: http://getbootstrap.com/getting-started/#download-cdn

@mdo mdo referenced this pull request Oct 24, 2015
Closed

v3.3.6 ship list #16644

@cvrebert cvrebert added a commit that referenced this pull request Oct 24, 2015
@cvrebert cvrebert Port #17729 to v4: Add SRI hashes to CDN links in docs
[skip sauce]
3bc5fb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment