Add support for Meteor 1.2 #16877

Merged
merged 1 commit into from Jul 28, 2015

5 participants

@rclai
rclai commented Jul 24, 2015

This is a refactor to prepare for the upcoming Meteor 1.2 release as well as any preview versions up to that point.

The { isAsset: true } is backwards compatible, it's just that once 1.2 comes around, it will be required for those kinds of files.

See this issue for more details.

@cvrebert
Bootstrap member

CC: @splendido @dandv for review

@cvrebert cvrebert added the meta label Jul 24, 2015
@cvrebert cvrebert added this to the v3.3.6 milestone Jul 24, 2015
@dandv
dandv commented Jul 28, 2015

LGTM

@cvrebert cvrebert merged commit 335f486 into twbs:master Jul 28, 2015

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
@mdo mdo referenced this pull request Jul 28, 2015
Closed

v3.3.6 ship list #16644

@rclai
rclai commented Jul 28, 2015

Thanks guys 😄

I'm guessing that you guys will also push out an Atmosphere update too based on your ship list?

@dandv
dandv commented Jul 28, 2015

We're waiting to hear from MDG on an issue with the Atmosphere publish bot, then @splendido will be able to trigger a push (thanks!).

@rclai
rclai commented Jul 28, 2015

Oh I see, cool.

@zimme
zimme commented Sep 4, 2015

meteor admin maintainers twbs:bootstrap --add publishbot
and autopublish should be good to go again.

cc: @dandv

@rclai
rclai commented Sep 4, 2015

Before we do that, looks like we might need to revisit this again because { isAsset: true } is now deprecated. More details here.

Wondering if for maximum compatibility we should do something like:

if (api.addAssets) {
  // Use api.addAssets
} else {
  // Use api.addFiles with { isAsset: true }
}
@zimme
zimme commented Sep 4, 2015

Oh yeah, it's api.addAssets() now IIRC.

@zimme
zimme commented Sep 4, 2015

If we don't wanna set versionsFrom to 1.2 then that approach looks like it's the better one.

@dandv
dandv commented Sep 5, 2015

Just ran meteor admin maintainers twbs:bootstrap --add publishbot.

@splendido

Would this be just to let people use twbs:[email protected] with newer meteor releases?

In version 4 it seems fonts won't be included anymore. See the output of meteor show --show-all twbs:bootstrap and #17318
I have no idea about the timeline for v4 and whether other 3.x.x versions will be released before it though...

@zimme
zimme commented Sep 6, 2015

They have.a ship list for 3.3.6 so I guess at least that will nees for both current meteor and 1.2+

@rclai
rclai commented Sep 24, 2015

Guys, here's a new PR now that Meteor 1.2 is out.

@cvrebert cvrebert added the meteor label Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment