text-emphasis-variant mixin should change the anchor's "focused" state as well #16047
+1
−1
3 participants
(Note to team: If approved, this will require rebasing prior to merging so that the commit message can be changed to something more descriptive.)
monoblaine
changed the title from Update text-emphasis.less to text-emphasis-variant mixin should change the anchor's "focused" state as well 
less/mixins/text-emphasis.less
| @@ -2,7 +2,7 @@ | ||
| .text-emphasis-variant(@color) { | ||
| color: @color; | ||
| - a&:hover { | ||
| + a&:hover, a&:focus { |
|
If we did this, this new selector would need to appear on the next line like so: a&:hover,
a&:focus {I'm happy to fix that when rebasing this. Do you approve, in principle, of adding the selector?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
|
This was referenced Mar 26, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The ".text-emphasis-variant" mixin does not change the anchor's color when the anchor is in the focused state, causing the link to have the default a:focus color (defined in https://github.com/twbs/bootstrap/blob/master/less/scaffolding.less#L53).