Input group sizes: Properly position `.form-control-feedback` #15956

Merged
merged 1 commit into from Mar 29, 2015

3 participants

@hnrch02
Bootstrap member
hnrch02 commented Mar 1, 2015

Ref #12868 (comment)
Ref 7733f24

Before: http://jsbin.com/hubiju/1
After: http://jsbin.com/hubiju/2

The reason I didn't convert the selector into something like this

.input-lg,
.input-group-lg {
  + .form-control-feedback { ... }
}

is that it would be mixed into here.

/cc @mdo

@hnrch02 hnrch02 Input group sizes: Properly position `.form-control-feedback`
fd35779
@hnrch02 hnrch02 added the css label Mar 1, 2015
@hnrch02 hnrch02 added this to the v3.3.4 milestone Mar 1, 2015
@cvrebert cvrebert modified the milestone: v3.3.5, v3.3.4 Mar 15, 2015
@mdo
Bootstrap member
mdo commented Mar 27, 2015

Looks good to me I think.

@mdo mdo merged commit e90d69c into master Mar 29, 2015

2 checks passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
Details continuous-integration/travis-ci/push The Travis CI build passed
@mdo mdo deleted the input-group-sizes-glyphicon branch Mar 29, 2015
@cvrebert cvrebert referenced this pull request Mar 29, 2015
Closed

v3.3.5 ship list #16074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment