[Fixes #15944] Add Z-Index to avoid border overlapping #15945

Merged
merged 1 commit into from Apr 5, 2015

6 participants

@kkirsche

[Fixes #15944] Add Z-Index to avoid border overlapping

@kkirsche kkirsche [Fixes #15944] Add Z-Index to avoid border overlapping
[Fixes #15944] Add Z-Index to avoid border overlapping
06cba30
@nextgenthemes

Nice but I am wondering if a z-index 2 (or any value for that matter) will not open up more problems when using this elements inside other z-indexed elements like modals and where bootstrap uses height z-indexes of 1000+ or just some custom z-indexed elements users may use.

@cvrebert cvrebert added the css label Feb 27, 2015
@vsn4ik
vsn4ik commented Feb 28, 2015

👍 for merge.

@kkirsche
kkirsche commented Mar 2, 2015

@twbs after reviewing the z-index variables from Variables.less should this be z-index: 1042 to accomodate @nextgenthemes comment.

@kkirsche
kkirsche commented Mar 5, 2015

Wanted to follow up on this and see what everyone thought.

@mdo
Bootstrap member
mdo commented Mar 8, 2015

Let's put together some examples via jsbin to see this stuff in action (the bug, the fix, and trying out a modal if you're concerned about z-index clashing).

@kkirsche

@mdo It seems to be working correctly with modals:

http://jsbin.com/nirafuvosu/1/edit?html,css,output

@twbs-lmvtfy
Bootstrap member

Hi @kkirsche!

You appear to have posted a live example (http://jsbin.com/nirafuvosu/1/edit), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

  • line 42, column 91: Duplicate ID exampleInputAmount.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)

@nextgenthemes

I guess I need to learn how z-indexes work when it comes to nesting and relatives, sorry.

@kkirsche

Wanted to follow up on this and check if it was missing anything.

@kkirsche

Wanted to follow up on this and check if it was missing anything.

@mdo
Bootstrap member
mdo commented Mar 27, 2015

Let's :shipit:.

@mdo mdo added this to the v3.3.5 milestone Mar 27, 2015
@mdo mdo merged commit 83d10bb into twbs:master Apr 5, 2015

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
@cvrebert cvrebert referenced this pull request Apr 5, 2015
Closed

v3.3.5 ship list #16074

@kkirsche kkirsche deleted the kkirsche:patch-9 branch Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment