/schemaorg

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove additional itemprop/property attribute on 'Book' example #185

Closed
wants to merge 1 commit into
from
+2 −2

Conversation

Reviewers
No reviews
Assignees

@danbri danbri

Labels
guidelines docs examples type:bug type:cleanup + clarity
Projects
None yet
Milestone
  sdo-stantz release
2 participants
@unor @danbri
@unor
Contributor

unor commented Nov 23, 2014

A Microdata/RDFa example had two itemprop/property elements on the same element, one of which contained an invalid property value (Fiction).

I guess it was intended to use content="Fiction" instead, but note that Microdata doesn’t allow this on span (see rvguha#184) and the JSON-LD example uses "fictional" instead of "Fiction", too.
@unor unor Fixed 'Book' example 
An example had two itemprop/property elements on the same element, one of which contained no valid property.
 dfb09d9

@unor unor changed the title from 'Book' example contained two itemprop/property attributes on same element to Remove additional itemprop/property attribute on 'Book' example Nov 23, 2014

@danbri danbri added guidelines docs examples status:needs review type:cleanup + clarity type:bug labels Jan 22, 2015

@danbri danbri modified the milestones: 2015 Q1, sdo-stantz release Jan 22, 2015

@danbri danbri self-assigned this Jan 22, 2015

@danbri danbri referenced this pull request Jan 22, 2015

Merged

Fixed 'Book' example #272

@danbri
Contributor

danbri commented Jan 22, 2015

Thanks! Merged in via #272 (I pulled it into sdo-stantz, our upcoming release, rather than master branch).

@danbri danbri closed this Jan 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment