rustbuild: Move pretty test suites to host-only #38665

Merged
merged 1 commit into from Dec 30, 2016

Projects

None yet

4 participants

@alexcrichton
Member

In an ongoing effort to optimize the runtime of the Android cross builder this
commit updates the pretty test suites to run only for host platforms, not for
target platforms as well. This means we'll still keep running all the suites but
we'll only run them for configured hosts, not for configured targets. This
notably means that we won't be running these suites on Android or musl targets,
for example.

@alexcrichton alexcrichton rustbuild: Move pretty test suites to host-only
In an ongoing effort to optimize the runtime of the Android cross builder this
commit updates the pretty test suites to run only for host platforms, not for
target platforms as well. This means we'll still keep running all the suites but
we'll only run them for configured hosts, not for configured targets. This
notably means that we won't be running these suites on Android or musl targets,
for example.
fc3e49b
@brson brson was assigned by rust-highfive Dec 28, 2016
@rust-highfive
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Member

Note that I consider this orthogonal to #38420 where I'd like to trim the number of pretty suites we run. In either case I think it's fine to only run the suites for host targets, not for all targets.

@brson
Contributor
brson commented Dec 29, 2016

This is fine if its what you want r+, but I'd also be happy completely removing them from the main suite and punting them to the cargotest bots.

@bors r+

@bors
Contributor
bors commented Dec 29, 2016

📌 Commit fc3e49b has been approved by brson

@alexcrichton alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 30, 2016
@alexcrichton alexcrichton Rollup merge of #38665 - alexcrichton:pretty-only-host, r=brson
rustbuild: Move pretty test suites to host-only

In an ongoing effort to optimize the runtime of the Android cross builder this
commit updates the pretty test suites to run only for host platforms, not for
target platforms as well. This means we'll still keep running all the suites but
we'll only run them for configured hosts, not for configured targets. This
notably means that we won't be running these suites on Android or musl targets,
for example.
2dc1a0a
@bors bors added a commit that referenced this pull request Dec 30, 2016
@bors bors Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
4a68076
@bors bors added a commit that referenced this pull request Dec 30, 2016
@bors bors Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
4536280
@bors bors added a commit that referenced this pull request Dec 30, 2016
@bors bors Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
c4908ce
@bors bors added a commit that referenced this pull request Dec 30, 2016
@bors bors Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
7f2d2af
@bors bors merged commit fc3e49b into rust-lang:master Dec 30, 2016

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
@bors
Contributor
bors commented Dec 30, 2016

⌛️ Testing commit fc3e49b with merge 7f2d2af...

@alexcrichton alexcrichton deleted the alexcrichton:pretty-only-host branch Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment