/rust

Fix fs tests on Windows systems with non-english locales. #38536

Merged
merged 1 commit into from Dec 26, 2016
+25 −20

Reviewers

No reviews

Assignees

@brson brson

Labels

None yet

Projects

None yet

Milestone

No milestone

7 participants

@retep998 @rust-highfive @petrochenkov @bors @daschl @est31 @brson
@retep998
Member
retep998 commented Dec 22, 2016 • edited

Fixes #34628

r? @alexcrichton
@brson brson was assigned by rust-highfive Dec 22, 2016
@rust-highfive
Collaborator
rust-highfive commented Dec 22, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)
@petrochenkov
Contributor
petrochenkov commented Dec 22, 2016

Does this fix #34628?
(That issue becomes more important because rustbuild doesn't allow manually skipping tests currently.)
@retep998 retep998 Fix fs tests on Windows systems with non-english locales.
This commit was signed with a verified signature.
@retep998 retep998 Peter Atashian
GPG key ID: DE04D9E27559BC8A Learn about signing commits

All checks have passed

2 successful checks
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
@bors homu — Test successful
23cfcdd
@retep998
Member
retep998 commented Dec 22, 2016

@petrochenkov It does now.
@petrochenkov
Contributor
petrochenkov commented Dec 23, 2016

@bors r+
@bors
Contributor
bors commented Dec 23, 2016

📌 Commit 23cfcdd has been approved by petrochenkov
@bors
Contributor
bors commented Dec 26, 2016

⌛️ Testing commit 23cfcdd with merge 8493dbe...
@bors bors added a commit that referenced this pull request Dec 26, 2016
@bors bors Auto merge of #38536 - retep998:flauschige-kaninchen, r=petrochenkov 
Fix fs tests on Windows systems with non-english locales.

Fixes #34628

r? @alexcrichton
 8493dbe
@bors
Contributor
bors commented Dec 26, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 8493dbe to master...
@bors bors merged commit 23cfcdd into rust-lang:master Dec 26, 2016
2 checks passed

2 checks passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
Details homu Test successful
@daschl
daschl commented Dec 26, 2016

@retep998 how did that branch name came to be? 😂
@est31
Contributor
est31 commented Dec 26, 2016

@daschl I've stumbled across this error on a german locale, and the 🐇 has fixed it :)
@brson brson referenced this pull request Dec 27, 2016
Open

Enable building complete release artifacts on Travis / Appveyor #38531

7 of 12 tasks complete
@petrochenkov
Contributor
petrochenkov commented Dec 27, 2016

Can confirm, with chcp 65001 all make check tests now pass on a totally non-English (Windows itself, locale, username, env vars) system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment