Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AO3-4976 Fix stray semicolons in autocomplete results with ampersands #2923

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
2 participants
Contributor

redsummernight commented May 29, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-4976

Purpose

Avoid highlighting an empty search term, which can split an ampersand entity, leaving a semicolon: &amp<b></b>;.

The minified js file is generated using uglify-js 3.0.12.

uglifyjs public/javascripts/jquery.tokeninput.js -o public/javascripts/jquery.tokeninput.min.js -c -m

Install (vagrant):

sudo apt install npm
sudo apt install nodejs-legacy
sudo npm install uglify-js -g

Testing

See issue.

On any field with autocomplete, search for something with ampersands (usually relationships). The search query should contain extra spaces, example: " term", "term ", "term 1". Without the fix, there will be semicolons.

AO3-4976 Fix stray semicolons in autocomplete results with ampersands
Avoid highlighting an empty search term, which can split an ampersand
entity, leaving a semicolon: "&amp<b></b>;".

sarken approved these changes May 30, 2017

Yay, this looks good -- thanks!

@sarken sarken merged commit e058efc into otwcode:master Oct 5, 2017

3 checks passed

Scrutinizer 1 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@redsummernight redsummernight deleted the redsummernight:AO3-4976-semicolon-tokeninput branch Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment