Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
AO3-4976 Fix stray semicolons in autocomplete results with ampersands #2923
Conversation
sarken
added
the
Reviewed: Ready to Merge
label
May 30, 2017
sarken
merged commit e058efc
into
otwcode:master
Oct 5, 2017
redsummernight
deleted the
redsummernight:AO3-4976-semicolon-tokeninput
branch
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
redsummernight commentedMay 29, 2017
Issue
https://otwarchive.atlassian.net/browse/AO3-4976
Purpose
Avoid highlighting an empty search term, which can split an ampersand entity, leaving a semicolon:
&<b></b>;.The minified js file is generated using uglify-js 3.0.12.
Install (vagrant):
Testing
See issue.
On any field with autocomplete, search for something with ampersands (usually relationships). The search query should contain extra spaces, example: " term", "term ", "term 1". Without the fix, there will be semicolons.