Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Apply same fix to radio buttons as for checkbox #3423
Comments
mbest
referenced this issue
in knockout/knockout
Dec 2, 2016
Closed
jQuery click on radio buttons doesn't trigger observable on first try #1722
markelog
added
Event
Needs review
labels
Dec 5, 2016
|
Yes, we appear to have a problem in Line 477 in f18ca7b using this.type === "checkbox" instead of rcheckableType.test( this.type ).
|
|
Hi there. I think we understand what you mean, but would you mind providing a test-case on http://jsbin.com/ or on similar resource? So it would be clear what behaviour you expect |
|
Such test case will also be necessary for a PR. Would you like to work on this, @mbest? |
markelog
removed
the
Needs review
label
Dec 5, 2016
mbest
commented
Dec 5, 2016
|
Here is the jsbin that was linked in the Knockout issue: http://jsbin.com/yinare/4/edit?html,js,output |
gibson042
added
the
help wanted
label
Dec 23, 2016
alexr101
referenced this issue
Jan 11, 2017
Closed
Event: Added rcheckable to click.trigger function #3494
gibson042
closed this
in
b442aba
Jan 19, 2017
added a commit
that referenced
this issue
Jan 19, 2017
timmywil
reopened this
Mar 20, 2017
timmywil
added this to the 3.3.0 milestone
Mar 20, 2017
|
This will be backed out due to the regression seen here. We will re-land with a fix for that regression in 3.3. |
|
Also see #1367 |
mbest
commented
Mar 20, 2017
•
|
Seems the same issue would apply to |
|
Right, but that's not a regression since 3.1.1. We plan to address that as well in 3.3. |
timmywil
assigned
gibson042
Mar 27, 2017
timmywil
removed
the
help wanted
label
Mar 27, 2017
timmywil
added
the
Blocker
label
Jun 19, 2017
gibson042
referenced this issue
Aug 9, 2017
Open
Trigger click event with specific namespace on checkboxes trigger click #3751
timmywil
modified the milestones:
3.3.0,
3.4.0
Jan 16, 2018
|
@gibson042 is working on this, but it will not make it in the 3.3 release. |
mbest commentedDec 2, 2016
See https://bugs.jquery.com/ticket/3827 and 1fb2f92
This fix should also include
radiobuttons. Currently if you use jQuery to trigger a click on a radio button, event handlers get called before thecheckedstate is updated. The release notes for 1.9.1 when the above change was included say it was changed for radio buttons even though it wasn't.