/JavaScriptServices

Fixup MSBuild conversion #721

Merged
merged 2 commits into from Mar 1, 2017
+31 −87

Reviewers

@SteveSandersonMS SteveSandersonMS

Assignees

No one assigned

Labels

cla-already-signed

Projects

None yet

Milestone

No milestone

3 participants

@natemcmaster @dnfclas @SteveSandersonMS
@natemcmaster
Member
natemcmaster commented Feb 28, 2017 • edited

This is a partial fix for the solution not building with MSBuild.

This is blocked by Microsoft/msbuild#1767
@natemcmaster natemcmaster Replace makefile.shade with repo.targets

All checks have passed

2 successful checks
continuous-integration/appveyor/branch — AppVeyor build succeeded
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
d8128ee
@natemcmaster natemcmaster requested a review from SteveSandersonMS Feb 28, 2017
@natemcmaster natemcmaster referenced this pull request Feb 28, 2017
Closed

Unify dependency versions across all projects #722

@dnfclas
dnfclas commented Feb 28, 2017

@natemcmaster,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot
@natemcmaster natemcmaster Remove web site projects as these are not yet supported by MSBuild fo… 
…r .NET Core

cref Microsoft/msbuild#1767

All checks have passed

2 successful checks
continuous-integration/appveyor/branch — AppVeyor build succeeded
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
4d38fcc
@natemcmaster natemcmaster changed the title from WIP: fixup MSBuild conversion to Fixup MSBuild conversion Feb 28, 2017
@natemcmaster
Member
natemcmaster commented Feb 28, 2017

@SteveSandersonMS I remove the Web Sites projects because of that MSBuild issue. If you still want this to work in VS, we could have two solutions in the file, one that has the Web Site projects (for working in VS) and one without it (for CI builds).
@SteveSandersonMS SteveSandersonMS merged commit 821ad85 into dev Mar 1, 2017
2 checks passed

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@SteveSandersonMS
Contributor
SteveSandersonMS commented Mar 1, 2017

Thanks for this @natemcmaster - it looks great! It's also nice to have the NPM restoration phase implemented here rather than in a hidden SDK, because we might want to swap out npm install for yarn at some point to make the builds go through faster.
@natemcmaster natemcmaster deleted the namc/vs2017 branch Mar 1, 2017
@natemcmaster
Member
natemcmaster commented Mar 1, 2017

+1 yarn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment