/growstuff

2016 12 gem upgrades #1126

Merged
merged 15 commits into from Dec 13, 2016

Reviewers

@pozorvlak pozorvlak

@Br3nda Br3nda

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

  Release 17

5 participants

@CloCkWeRX @coveralls @Br3nda @pozorvlak @cesy
@CloCkWeRX
Contributor
CloCkWeRX commented Dec 9, 2016

Was #1101
@CloCkWeRX CloCkWeRX referenced this pull request Dec 9, 2016
Closed

Updating a few gems #1101

CloCkWeRX added some commits Dec 9, 2016
@CloCkWeRX CloCkWeRX Disable Style/EmptyMethod for now

Some checks were not successful

1 failing and 1 successful checks
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
@maco codeclimate — no new or fixed issues
5235b11
@CloCkWeRX CloCkWeRX Upgrade

All checks have passed

2 successful checks
Details
@maco codeclimate — no new or fixed issues
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
be572b9
@coveralls
coveralls commented Dec 9, 2016 • edited

Coverage Status

Coverage remained the same at 88.39% when pulling be572b9 on CloCkWeRX:2016-12-gem-upgrades into 3e43a19 on Growstuff:dev.
.rubocop.yml
+ - 'db/seeds.rb'
+
+Style/EmptyMethod:
@Br3nda
Br3nda Dec 10, 2016 Contributor

If this is temporary, i think it should be in rubocop_todo.yml

@Br3nda
Br3nda Dec 10, 2016 Contributor

You can add ignores for the few files that have this, using:
bundle exec rubocop --auto-gen-config

@CloCkWeRX
CloCkWeRX Dec 12, 2016 • edited Contributor

Ah hah.

So, I can't decide - the single line cop looks stupid. I'm just going to drop us back to previous version, can make our minds up later

CloCkWeRX added some commits Dec 12, 2016
@CloCkWeRX CloCkWeRX Revert "Disable Style/EmptyMethod for now" 
This reverts commit 5235b11.
 6ff3fa2
@CloCkWeRX CloCkWeRX Revert "Update rake and rubocop" 
This reverts commit c9127db.
 74657ab
@CloCkWeRX CloCkWeRX Upgrade rake only

All checks have passed

2 successful checks
Details
@maco codeclimate — no new or fixed issues
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
feff2cd
@coveralls
coveralls commented Dec 12, 2016

Coverage Status

Coverage remained the same at 88.39% when pulling feff2cd on CloCkWeRX:2016-12-gem-upgrades into 3e43a19 on Growstuff:dev.
@coveralls
coveralls commented Dec 12, 2016

Coverage Status

Coverage remained the same at 88.39% when pulling feff2cd on CloCkWeRX:2016-12-gem-upgrades into 3e43a19 on Growstuff:dev.
spec/spec_helper.rb
@@ -14,8 +14,8 @@
# users commonly want.
#
# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
-require "codeclimate-test-reporter"
@pozorvlak
pozorvlak Dec 12, 2016 Member

What's this change for?

@CloCkWeRX
CloCkWeRX Dec 13, 2016 Contributor

Check out
https://github.com/codeclimate/ruby-test-reporter/blob/master/CHANGELOG.md
(v1.0.0)

@pozorvlak
pozorvlak Dec 13, 2016 Member

Gotcha, thanks. I note that it says

Now, you are responsible for running codeclimate-test-reporter as a separate step in your build.

do we need to update .travis.yml?

@CloCkWeRX
CloCkWeRX Dec 14, 2016 Contributor

We likely do, overlooked that
CODECLIMATE_REPO_TOKEN=<token> bundle exec codeclimate-test-reporter

@Br3nda
Br3nda approved these changes Dec 13, 2016 View changes
@CloCkWeRX CloCkWeRX merged commit 148dfa7 into Growstuff:dev Dec 13, 2016
2 checks passed

2 checks passed

Details codeclimate no new or fixed issues
Details continuous-integration/travis-ci/pr The Travis CI build passed
@CloCkWeRX CloCkWeRX deleted the CloCkWeRX:2016-12-gem-upgrades branch Dec 13, 2016
@CloCkWeRX CloCkWeRX removed the in progress label Dec 13, 2016
@cesy cesy modified the milestone: Release 17 Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment