/growstuff

Gardens query was running twice in contoller #1122

Merged
merged 1 commit into from Dec 7, 2016

Reviewers

@pozorvlak pozorvlak

@CloCkWeRX CloCkWeRX

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

  Release 17

6 participants

@Br3nda @CloCkWeRX @pozorvlak @coveralls @maco @cesy
@Br3nda
Contributor
Br3nda commented Dec 7, 2016

No description provided.

@maco maco added the in progress label Dec 7, 2016
@CloCkWeRX
Contributor
CloCkWeRX commented Dec 7, 2016

In theory, that just built an SQL string until you read from the enumerable put into @gardens; so that shouldn't have been a huge perf deal.

LGTM, once the CC complaint is sorted
@pozorvlak
pozorvlak approved these changes Dec 7, 2016 View changes

+1 once CI passes.

@pozorvlak
Member
pozorvlak commented Dec 7, 2016

Looks fine apart from the CC issue; I'm worried by the Travis failure, though that looks unrelated - @maco, any idea what's going on there?
@Br3nda Br3nda FIX Gardens query was running twice in contoller

All checks have passed

2 successful checks
Details
@maco codeclimate — no new or fixed issues
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
e695d56
@coveralls
coveralls commented Dec 7, 2016

Coverage Status

Coverage remained the same at 87.765% when pulling e695d56 on Br3nda:bw/duplicate-query into e799233 on Growstuff:dev.
@Br3nda
Contributor
Br3nda commented Dec 7, 2016

@pozorvlak i've fixed the rubocop complaint and re-run the travis ci
@Br3nda Br3nda merged commit aea935b into Growstuff:dev Dec 7, 2016
2 checks passed

2 checks passed

Details codeclimate no new or fixed issues
Details continuous-integration/travis-ci/pr The Travis CI build passed
@Br3nda Br3nda deleted the Br3nda:bw/duplicate-query branch Dec 7, 2016
@maco maco removed the in progress label Dec 7, 2016
@cesy cesy modified the milestone: Release 17 Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment