Bw/bar graphs #1121
I don't think that's used anywhere else (its... orange); though we do have
Weirdly; #b2685c is completely not orange. I didn't quite see where it was used in the UI looking at the code only |
|
I think with the d3 'similar code', its just going to be something we ignore. Specifically:
|
Kind of keen to see if we can |
| @@ -0,0 +1,124 @@ | ||
| +# src_files |
I wonder if spec/javascript will execute in travis automagically, or if we have to invoke something else.
Generally like jasmine for complex JS testing
That would be awesome, but it's not the end of the world if we add another line to .travis.yml.
In general, I'm +10000 to us adding JavaScript unit tests via some means, and I'm not too bothered about which framework we use.
It doesn't look like the tests are being run in Travis; if I run rspec spec/javascripts locally I get 0 tests executed. @Br3nda, how are you invoking the tests locally?
Once we knock off the code climate complaints, I'm pretty happy with this.
Afterwards, lets make sure jasmine runs in travis by default.
In the original PR, it talked about connecting this up to "real data"; so let's focus on that in subsequent tickets.
In the original PR, @cesy I think was curious about how it worked for screenreaders - the default answer is "it doesn't work" for now, but lets investigate that more.
|
The one-line duplication between The "similar code found between bar_group.js and bar_label_group.js" issue looks like a false positive to me - sure, we could factor out some common code, but the similarity is superficial so we wouldn't gain anything thereby. To ignore it, add
|
|
Oh, @CloCkWeRX already said everything I did a fortnight ago. D'oh. Oh well, at least I'm somewhat up to speed with the issues now. |
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map - mostly. |
|
We can use jQuery.map: we're already using jQuery. |
I think PR #688 is awesome, so here is it with the merge conflicts fixed.