/growstuff

add photos to seeds #1109

Merged
merged 7 commits into from Dec 4, 2016

Reviewers

@Br3nda Br3nda

@CloCkWeRX CloCkWeRX

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

  Release 17

5 participants

@maco @coveralls @Br3nda @CloCkWeRX @cesy
@maco
Member
maco commented Dec 1, 2016

Fixes #495

untested, waiting on #1106 and #1107
@maco maco add photos to seeds 
Fixes #495

Some checks were not successful

1 failing and 1 successful checks
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
@maco codeclimate — Code Climate didn't find any new or fixed issues.
637b46e
@maco maco added the in progress label Dec 1, 2016
@coveralls
coveralls commented Dec 1, 2016 • edited

Coverage Status

Coverage decreased (-0.2%) to 87.511% when pulling 637b46e on maco:seed_photos into 5cb1e14 on Growstuff:dev.
@maco maco include the migration

All checks have passed

2 successful checks
Details
@maco codeclimate — Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
a3c8bc0
@coveralls
coveralls commented Dec 1, 2016 • edited

Coverage Status

Coverage increased (+0.01%) to 87.688% when pulling a3c8bc0 on maco:seed_photos into 5cb1e14 on Growstuff:dev.
@Br3nda Br3nda Merge branch 'dev' into seed_photos

All checks have passed

2 successful checks
Details
@maco codeclimate — Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
077c807
@CloCkWeRX
CloCkWeRX approved these changes Dec 2, 2016 View changes

Any UI work to go along with it (default photos, partials, etc?) Can do as a seperate PR too

@coveralls
coveralls commented Dec 2, 2016 • edited

Coverage Status

Coverage increased (+0.01%) to 87.688% when pulling 077c807 on maco:seed_photos into 266455e on Growstuff:dev.
@Br3nda
Contributor
Br3nda commented Dec 2, 2016 • edited

Does the photo_mappings table not replace the photo_seeds photo_crops tables etc?
@maco
Member
maco commented Dec 2, 2016

@Br3nda after talking to @CloCkWeRX i learned that having a table that has fake foreign keys to multiple tables based on a column is a crappy database performance thing so we should stick to ordinary join tables. Thus, did not do photo_mappings after all.
@Br3nda Br3nda Merge branch 'dev' into seed_photos

All checks have passed

2 successful checks
Details
@maco codeclimate — Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
7785a9d
@Br3nda
Contributor
Br3nda commented Dec 2, 2016 • edited

@maco the creation of table photo_mappings is still in this pr.
@Br3nda
Br3nda requested changes Dec 2, 2016 View changes

I think you need to regenerate schema.db

db/schema.rb
@@ -355,6 +355,14 @@
t.integer "product_id"
end
+ create_table "photo_mappings", force: :cascade do |t|
@Br3nda
Br3nda Dec 2, 2016 Contributor

Should this table still be here?

@maco
maco Dec 3, 2016 Member

oooo good catch

@coveralls
coveralls commented Dec 2, 2016 • edited

Coverage Status

Coverage increased (+0.01%) to 87.688% when pulling 7785a9d on maco:seed_photos into 519cf80 on Growstuff:dev.
maco added some commits Dec 3, 2016
@maco maco correct schema and add index for photos_seeds c201200
@maco maco Merge branch 'seed_photos' of gitmaco:maco/growstuff into seed_photos

All checks have passed

2 successful checks
Details
@maco codeclimate — Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
c2de65e
@coveralls
coveralls commented Dec 3, 2016

Coverage Status

Coverage increased (+0.02%) to 87.694% when pulling c2de65e on maco:seed_photos into 519cf80 on Growstuff:dev.
@coveralls
coveralls commented Dec 3, 2016

Coverage Status

Coverage increased (+0.02%) to 87.694% when pulling c2de65e on maco:seed_photos into 519cf80 on Growstuff:dev.
@CloCkWeRX CloCkWeRX Merge branch 'dev' into seed_photos

All checks have passed

2 successful checks
Details
@maco codeclimate — Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
8bb6df6
@coveralls
coveralls commented Dec 3, 2016 • edited

Coverage Status

Coverage increased (+0.01%) to 87.694% when pulling 8bb6df6 on maco:seed_photos into 04ba871 on Growstuff:dev.
@CloCkWeRX
Contributor
CloCkWeRX commented Dec 3, 2016
@Br3nda
Br3nda approved these changes Dec 3, 2016 View changes
@CloCkWeRX CloCkWeRX merged commit 1ae9366 into Growstuff:dev Dec 4, 2016
2 checks passed

2 checks passed

Details codeclimate Code Climate didn't find any new or fixed issues.
Details continuous-integration/travis-ci/pr The Travis CI build passed
@CloCkWeRX CloCkWeRX removed the in progress label Dec 4, 2016
@cesy cesy modified the milestone: Release 17 Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment