/growstuff

expand wikipedia regex to include -, (, and ) #1105

Merged
merged 2 commits into from Dec 2, 2016

Reviewers

@CloCkWeRX CloCkWeRX

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

  Release 17

4 participants

@maco @coveralls @CloCkWeRX @cesy
@maco
Member
maco commented Dec 1, 2016

because some have - or () in name

example:

(Fixes: #1104)
@maco maco expand wikipedia regex to include punctuation, because some have - or… 
… () in name

(Fixes: #1104)

Some checks were not successful

1 failing and 1 successful checks
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
@maco codeclimate — Code Climate didn't find any new or fixed issues.
54628e6
@maco maco added the in progress label Dec 1, 2016
@coveralls
coveralls commented Dec 1, 2016 • edited

Coverage Status

Coverage remained the same at 87.677% when pulling 54628e6 on maco:wikipedia_regex into 5cb1e14 on Growstuff:dev.
@maco maco narrow the regex back down 
hyphen must be the LAST thing in the character class

All checks have passed

2 successful checks
Details
@maco codeclimate — Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
2fb34be
@coveralls
coveralls commented Dec 1, 2016 • edited

Coverage Status

Coverage remained the same at 87.677% when pulling 2fb34be on maco:wikipedia_regex into 5cb1e14 on Growstuff:dev.
@maco maco changed the title from expand wikipedia regex to include punctuation to expand wikipedia regex to include -, (, and ) Dec 1, 2016
@CloCkWeRX CloCkWeRX merged commit 266455e into Growstuff:dev Dec 2, 2016
2 checks passed

2 checks passed

Details codeclimate Code Climate didn't find any new or fixed issues.
Details continuous-integration/travis-ci/pr The Travis CI build passed
@CloCkWeRX CloCkWeRX removed the in progress label Dec 2, 2016
@cesy cesy modified the milestone: Release 17 Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment