/growstuff

Update rails #1102

Merged
merged 1 commit into from Dec 1, 2016

Reviewers

@CloCkWeRX CloCkWeRX

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

  Release 17

4 participants

@cesy @coveralls @CloCkWeRX @maco
@cesy
Member
cesy commented Dec 1, 2016

Let's update the gemfile to show we're on 4.2.7.1. Then we can think about when we want to upgrade to 5.
@cesy cesy Update rails

All checks have passed

2 successful checks
Details
@maco codeclimate — Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
3d845f4
@maco maco added the in progress label Dec 1, 2016
@coveralls
coveralls commented Dec 1, 2016

Coverage Status

Coverage remained the same at 87.439% when pulling 3d845f4 on cesy:railsupdate into 547e640 on Growstuff:dev.
@coveralls
coveralls commented Dec 1, 2016

Coverage Status

Coverage remained the same at 87.439% when pulling 3d845f4 on cesy:railsupdate into 547e640 on Growstuff:dev.
@CloCkWeRX
CloCkWeRX approved these changes Dec 1, 2016 View changes

LGTM, but the ~> indicator was shorthand enough for this anyhow - will install the latest 4.2.* on bundle update.

Rails 5, give it a whirl but I think we have some upstream gems that need to migrate first - comfy cms?

@CloCkWeRX CloCkWeRX merged commit 83a3c3e into Growstuff:dev Dec 1, 2016
2 checks passed

2 checks passed

Details codeclimate Code Climate didn't find any new or fixed issues.
Details continuous-integration/travis-ci/pr The Travis CI build passed
@CloCkWeRX CloCkWeRX removed the in progress label Dec 1, 2016
@cesy cesy modified the milestone: Release 17 Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment