/wp-super-cache

Remove `flush()` call in wp_cache_get_response_headers() #127

Merged
merged 1 commit into from Feb 3, 2017
+0 −1

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

  1.4.9

3 participants

@zytzagoo @kraftbj @donnchawp
@zytzagoo
Contributor
zytzagoo commented Aug 11, 2016

For more details see: #126

Fixes #126
@kraftbj
Contributor
kraftbj commented Aug 11, 2016

At first read, your explanation and process makes sense to me. Donncha (primary dev) is on vacation and want to get his nod for modifying something this ancient ;-).
@kraftbj kraftbj added this to the 1.4.9 milestone Aug 11, 2016
@kraftbj kraftbj added the bug label Aug 11, 2016
@donnchawp
Contributor
donnchawp commented Feb 3, 2017

We should check it in BUT we'll have to modify it because for some reason apache_response_headers() doesn't always behave and needs flush() to do the job. See this comment for more details.

I'll check the headers and if it's empty I'll call flush() and get the headers again.
@donnchawp donnchawp merged commit 67c53e9 into Automattic:master Feb 3, 2017
@donnchawp donnchawp added a commit that referenced this pull request Feb 3, 2017
@donnchawp donnchawp Check if headers are empty and then flush and get the headers again 
In #127 flush() was removed but a comment on apache_response_headers()
said that function may return an empty array, so I check for that here
and do a flush() before getting the headers again.
 8349ab7
@donnchawp donnchawp referenced this pull request Feb 3, 2017
Merged

Check if headers are empty and then flush and get the headers again #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment