/refined-github

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Show more than three Avatars for Reactions #644

Merged
merged 5 commits into from Jul 27, 2017
+58 −28

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement
Milestone
No milestone
2 participants
@bfred-it @sindresorhus
@bfred-it
Collaborator

bfred-it commented Jul 26, 2017 • edited

Fixes #240

Testable on babel/babel#3646

more than 3 avatars

Still limited and compressed when they don't fit:

lots of avatars

Since this is now in JS, limited avatars won't be loaded at all (contrary to what happened before)

bfred-it added some commits Jul 26, 2017

@bfred-it bfred-it Show more reaction-avatars
053ea66
@bfred-it bfred-it Drop logging e791097
@bfred-it bfred-it Move flatZip to utils d69dc95
@bfred-it bfred-it Save a few loops and instructions by dropping out early 
+ cool, finally I can use Infinity!

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
35b18c0

@bfred-it bfred-it added enhancement bug labels Jul 26, 2017

@bfred-it
Collaborator

bfred-it commented Jul 26, 2017

Also fixes this bug (selector was broken and was hiding more avatars than necessary):
@bfred-it bfred-it Load smaller image 
That’s like a 30x size decrease!

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
668a720
@bfred-it
Collaborator

bfred-it commented Jul 26, 2017

Loading 460x460 images bothered me, so thanks to this we load 40x40 or 20x20 images: https://stackoverflow.com/a/36380674/288906
@sindresorhus
Owner

sindresorhus commented Jul 27, 2017

Looks good. Another issue to test it with: facebook/react#10191

@sindresorhus sindresorhus merged commit 40653f3 into master Jul 27, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sindresorhus sindresorhus deleted the all-the-musketeers branch Jul 27, 2017

@bfred-it
Collaborator

bfred-it commented Jul 27, 2017

Excellent testbed. I already found a line that wraps:

screen shot 2017-07-27 at 17 58 39

Also this thread on hover facebook/react#8854

screen shot 2017-07-27 at 18 05 30

@bfred-it bfred-it referenced this pull request Jul 27, 2017

Merged

Lower avatar limit #649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment