Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Switch license to Apache 2 #5698
Comments
|
Need to confirm the recent React concerns won't affect us. |
dcramer
added a commit
that referenced
this issue
Jul 17, 2017
|
|
dcramer |
53c77f9
|
dcramer
added a commit
that referenced
this issue
Jul 17, 2017
|
|
dcramer |
0cac36f
|
|
So one concern, and I'm not sure if avoidable, we need to add license headers to files to be correct via Apache. This IS possible to do, but is not going to be fun. Facebook does it via Phabricator, and we could do it via pre-commit/ |
dcramer
added a commit
that referenced
this issue
Jul 17, 2017
|
|
dcramer |
ca337e0
|
|
Aside once we fully resolve this, let's plan to transition all SDKs and open source work from Sentry to the same structure. I dont THINK there will be any concerns from upsteam users on those, but we will be confirming with legal advisor first, and might offer dual license options. |
janl
commented
Jul 17, 2017
|
Just curious, what’s the goal here? You’re using a standard 3-clause BSD license afaict, which is very permissive already and you don’t have the patents addition that Facebook added to react. The react story thus is unrelated. As for license headers, that’s not an ASL2 requirement, just ASF policy for its own projects. Were you too witch to ASL2, all you need is copying the license text into your |
|
@janl good to know (re: LICENSE file). My concerns were more around we're not actually declaring who the copyright holder(s) are anywhere given the standard Apache text doesnt include anything. Our goal is a more universally understood license with potential future protections. Given that Sentry's a growing business, it's possible we may want/need to take advantage of the patents protections Apache offers (down the road), as well as having access to the CLA (though we may never use it). Apache is also the most understand on the legal side, and its something we've more or less standardized on in newer projects for quite a while. (Aside we had talked about the React bit internally, and that was the same conclusion we came to, as it was just a misunderstanding) |
janl
commented
Jul 18, 2017
|
@dcramer that’s all well thought out, keep going :) #asfmemberout |
dcramer commentedJul 10, 2017
Let's do it.