AO3-3359 Add search button to top of advanced search form #2641

Merged
merged 3 commits into from May 4, 2017

Conversation

Projects
None yet
2 participants
Contributor

pixelred commented Nov 28, 2016

Issue

https://otwarchive.atlassian.net/browse/AO3-3359

Purpose

adds a search button to the top of the advanced search form, and removes top padding from the new button to preserve the balance/symmetry of the page. (tried to make sure the selector would only target that one submit button, since this styling isn't necessary for any other buttons i don't think...)

Testing

the changes shouldn't affect any other forms (or submit buttons) on the site.

@pixelred pixelred AO3-3359 add search button to top of advanced search form
943f8a2

sarken self-assigned this Nov 28, 2016

Owner

sarken commented Nov 28, 2016

Assigning myself to this -- will take a look when I have a minute!

Contributor

pixelred commented Nov 28, 2016

okay! ✌️

i read that AO3 uses CSS 2.1 except for certain CSS3 properties like box shadow... and first-of-type is a CSS3 selector. but i also wasn't sure how else to target that one button using CSS 2.1 without giving the button its own class or ID. also wasn't sure if i should use padding-top or just redefine the padding using 4 numbers.

@sarken

I took a look at this, and honestly, I wouldn't want to create a design pattern based on this particular form in its current state. >.> So! Could you move the new CSS to the sandbox.css file, and then we'll just mark this ready to merge?

@pixelred pixelred AO3-3359 removed changes to form and stylesheets and moved them to sa…
…ndbox.css
4d9e254
Contributor

pixelred commented Apr 29, 2017

okay! done ✌️ did i add too much info to the sandbox comment;;

Owner

sarken commented May 1, 2017

Oh, sorry! I meant leave the HTML change in the form and just put the CSS in the sandbox like the rule for .edit_external_author ul ul is in there. We do want to merge and deploy the change for users to use; we're just not quite sure how the "button at the top of a form" design pattern is going work in the long term, so the styles should go in sandbox for now.

@pixelred pixelred AO3-3359 re-add button to page but keep styling in sandbox
4eaf4d6
Contributor

pixelred commented May 1, 2017

ahh okay! sorry about that. if i understood correctly then: the html should be applied to the form, but the css should not be applied to 08-actions and should instead be left in the sandbox (that's what i've done in this last commit)

Owner

sarken commented May 1, 2017

Yep, you got it! 👍

@sarken

sarken approved these changes May 1, 2017

@sarken sarken merged commit cb799c7 into otwcode:master May 4, 2017

3 checks passed

Scrutinizer 11 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment