AO3-3359 Add search button to top of advanced search form #2641
Conversation
sarken
self-assigned this
Nov 28, 2016
sarken
added the
Awaiting review
label
Nov 28, 2016
|
Assigning myself to this -- will take a look when I have a minute! |
|
okay! i read that AO3 uses CSS 2.1 except for certain CSS3 properties like box shadow... and first-of-type is a CSS3 selector. but i also wasn't sure how else to target that one button using CSS 2.1 without giving the button its own class or ID. also wasn't sure if i should use padding-top or just redefine the padding using 4 numbers. |
sarken
requested changes
Apr 29, 2017
I took a look at this, and honestly, I wouldn't want to create a design pattern based on this particular form in its current state. >.> So! Could you move the new CSS to the sandbox.css file, and then we'll just mark this ready to merge?
sarken
added Reviewed: Needs Coder Action and removed Awaiting review
labels
Apr 29, 2017
|
okay! done |
|
Oh, sorry! I meant leave the HTML change in the form and just put the CSS in the sandbox like the rule for |
|
ahh okay! sorry about that. if i understood correctly then: the html should be applied to the form, but the css should not be applied to 08-actions and should instead be left in the sandbox (that's what i've done in this last commit) |
|
Yep, you got it! |
pixelred commentedNov 28, 2016
Issue
https://otwarchive.atlassian.net/browse/AO3-3359
Purpose
adds a search button to the top of the advanced search form, and removes top padding from the new button to preserve the balance/symmetry of the page. (tried to make sure the selector would only target that one submit button, since this styling isn't necessary for any other buttons i don't think...)
Testing
the changes shouldn't affect any other forms (or submit buttons) on the site.