[ARM32/Linx] cross-architecture build: restrict build project list #8918

Merged
merged 2 commits into from Jan 17, 2017

Projects

None yet

4 participants

@hseok-oh
Contributor
hseok-oh commented Jan 12, 2017 edited

Restrict build project for ARM32/Linux cross-architecture
We can build these projects. (release build)

  • crossgen
  • clrjit
  • protojit

Support these first, and others later.
We can't build cross-architecture mscordaccore, mscordbi and sos in Linux yet. But crossgen can be used to generate ni files, and superpmi(generated by clrjit) and protojit can be used to implement Ryujit ARM32.

@hseok-oh hseok-oh [ARM32/Linx] cross-architecture build: restrict build project list
Restrict build project for ARM32/Linux cross-architecture
We can build these projects with PR #8866 and #8917. (release build)
- crossgen
- clrjit
- protojit
8ff52db
crosscomponents.cmake
-)
+)
+
+if(CLR_CMAKE_PLATFORM_LINUX AND CLR_CMAKE_TARGET_ARCH_ARM)
@janvorli
janvorli Jan 12, 2017 Member

Can you please add just what's needed instead of adding and then removing stuff? And why do we actually need to restrict the list for ARM Linux?

@hseok-oh
hseok-oh Jan 12, 2017 Contributor

@janvorli OK. I'll modify to set list for ARM using if-else.

By building these projects, we can get cross-architecture crossgen and superpmi (release build). And to building other projects, need to fix more build error.

@hseok-oh hseok-oh modify crosscomponents.cmake
Add list items when not Linux, instead remove in Linux
c5d2a25
@janvorli
Member

@hseok-oh could you please add explanation why we don't build the mscordaccore, mscordbi and sos on Unix to the first comment in this PR?

@hseok-oh
Contributor

@janvorli Not don't. We can't build cross-architecture mscordaccore, mscordbi and sos in Linux yet. But crossgen can be used to generate ni files, and superpmi(generated by clrjit) and protojit can be used to implement Ryujit ARM32. I want to support these first, and others later.

@janvorli
Member

@hseok-oh thanks for the clarification.

@hseok-oh
Contributor

@janvorli I added explanation to first comment. Thanks.

@hseok-oh
Contributor

@dotnet-bot test Ubuntu x64 Checked Build and Test please

@hqueue
Contributor
hqueue commented Jan 17, 2017

LGTM thanks!

@janvorli

LGTM, thank you!

@janvorli janvorli merged commit 69c5538 into dotnet:master Jan 17, 2017

13 checks passed

CentOS7.1 x64 Debug Build and Test Build finished.
Details
FreeBSD x64 Checked Build Build finished.
Details
Linux ARM Emulator Cross Debug Build Build finished.
Details
Linux ARM Emulator Cross Release Build Build finished.
Details
OSX x64 Checked Build and Test Build finished.
Details
Ubuntu x64 Checked Build and Test Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
Windows_NT arm Cross Debug Build Build finished.
Details
Windows_NT arm Cross Release Build Build finished.
Details
Windows_NT x64 Debug Build and Test Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x64 Release Priority 1 Build and Test Build finished.
Details
Windows_NT x86 Checked Build and Test Build finished.
Details
@hseok-oh hseok-oh deleted the hseok-oh:cac-project-arm branch Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment