cli: Clarify how default command line options are enabled #435

Merged
merged 1 commit into from Jan 6, 2017

Projects

None yet

2 participants

@sschuberth
Collaborator

No description provided.

@sschuberth sschuberth cli: Clarify how default command line options are enabled
f827cdc
@pombredanne
Member

Good catch. This was not enough indeed. In fact I truly think that all scans may be best always enabled by default and that if you pass a specific scan option, then only that scan would be used.
Now to for this to be practical #384 would need to be there first as otherwise there are cases not so uncommon where you end up with data files with 1000's of urls or emails and that does not make sense to capture them all by default.

@pombredanne
Member

Merging.... Thanks! .... btw @sschuberth do you want commit rights directly on the repo? that could make it easier? your call! you definitely earned it in any case.

@pombredanne pombredanne merged commit d01aa0d into nexB:develop Jan 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sschuberth
Collaborator

do you want commit rights directly on the repo?

I'd indeed appreciate that as it would simply the workflow a bit by me creating branches in your repo instead of my fork.

@sschuberth sschuberth deleted the sschuberth:clarify-default-options branch Jan 6, 2017
@pombredanne
Member

@sschuberth great. Invite sent! 🙇

@pombredanne
Member

of note: force pushing is disabled/protected (for everyone) on the master and develop branches for sanity. This is fair game in any other branches otherwise.

@sschuberth
Collaborator

Sure thing!

@pombredanne
Member

This is just an FYI... force pushing would fail if attempted on master and develop :)

@pombredanne
Member

even by me... I do not trust me in particular ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment