/blessed

strict mode fixes #214

Merged
merged 2 commits into from Jan 4, 2016

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@dbkaplun @chjj @ivan-kleshnin
@dbkaplun
Collaborator
dbkaplun commented Jan 3, 2016

Implements support for compilation via babel-preset-es2015.
@chjj
Owner
chjj commented Jan 4, 2016

Dammit, why did they have to remove octal literals? That will always get to me.

Anyway, looks good, but can we change the parseInt('0377')s to 255 or 0xff? I originally used 0377 there because that's what ncurses does and I wanted the code to be as similar to ncurses as possible. Those numbers being octal never really made sense in the first place though.

The parseInt('0200') could also stand to be changed to a hex literal.
@dbkaplun
Collaborator
dbkaplun commented Jan 4, 2016

Yeah it's silly that octals are not allowed in the form 0### in ES6. Seems to break backwards compatibility if you ask me.

Fixes in ba1982d
@chjj chjj merged commit eab243f into chjj:master Jan 4, 2016
@dbkaplun dbkaplun deleted the dbkaplun:strict-mode-fixes branch Jan 4, 2016
@ivan-kleshnin
ivan-kleshnin commented Apr 12, 2016

Any chance of releasing this fix?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment