Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Revert "AO3-4466 Reduce the one call to skins per page" #2510
Conversation
houndci-bot
reviewed
Aug 14, 2016
| @@ -53,8 +51,7 @@ def self.guest_downloading_off? | ||
| self.first ? self.first.guest_downloading_off? : false | ||
| end | ||
| def self.default_skin | ||
| - default_skin = Rails.cache.fetch(default_skin_cache_key) { Skin.default } | ||
| - self.first ? (self.first.default_skin_id ? self.first.default_skin : default_skin) : default_skin | ||
| + self.first ? (self.first.default_skin_id ? self.first.default_skin : Skin.default) : Skin.default |
houndci-bot
Aug 14, 2016
Ternary operators must not be nested. Prefer if/else constructs instead.
Redundant self detected.
zz9pzza
merged commit c2a0e27
into
master
Aug 14, 2016
zz9pzza
referenced this pull request
Aug 14, 2016
Open
AO3-4466 Reduce the one call to skins per page #2511
zz9pzza
deleted the
revert-2332-AO3-4466
branch
Aug 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zz9pzza commentedAug 14, 2016
Reverts otwcode/otwarchive#2332