/rustfmt

Include git commit and worktree status in version output #1060

Merged
merged 1 commit into from Jun 12, 2016
+85 −5

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@kamalmarhubi @marcusklaas
@kamalmarhubi
Contributor
kamalmarhubi commented Jun 10, 2016

This will help in debugging issues as rustfmt gets more users.

If the working tree is clean, output looks like

$ target/debug/rustfmt -V
0.5.0 (9f5ed3b)

If the working tree is dirty, output looks like

$ target/debug/rustfmt -V
0.5.0 (9f5ed3b worktree dirty)

If git is unavailable, output looks like

$ target/debug/rustfmt -V
0.5.0 (git commit unavailable)

To avoid rebuilds on changing tests, the build script will only rerun if
files under src/ are changed. This means the actual git status may show
changed files and this would not show up in the version. This should not
be an issue as files not in src/ should not affect the build output.
@kamalmarhubi
Contributor
kamalmarhubi commented Jun 10, 2016

I suggest testing this yourself before merging. You can check it out with git fetch origin refs/pull/1060/head && git checkout FETCH_HEAD.
@marcusklaas
Contributor
marcusklaas commented Jun 10, 2016

👍
@kamalmarhubi kamalmarhubi Include git commit and worktree status in version output 
This will help in debugging issues as rustfmt gets more users.

If the working tree is clean, output looks like

    $ target/debug/rustfmt -V
    0.5.0 (9f5ed3b)

If the working tree is dirty, output looks like

    $ target/debug/rustfmt -V
    0.5.0 (9f5ed3b worktree dirty)

If git is unavailable, output looks like

    $ target/debug/rustfmt -V
    0.5.0 (git commit unavailable)

To avoid rebuilds on changing tests, the build script will only rerun if
files under src/ are changed. This means the actual git status may show
changed files and this would not show up in the version. This should not
be an issue as files not in src/ should not affect the build output.
9e203a4
@marcusklaas marcusklaas merged commit 5361f61 into rust-lang-nursery:master Jun 12, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment