[RFC] Short list syntax #1849

bwoebi · Apr 5, 2016

See: https://wiki.php.net/rfc/short_list_syntax

Missing test for error on [42] = ... and similar.

I've not added many [] tests, it's using the exactly same syntax (array_pair_list) in parser and the differences are abstracted away inside AST.
If there would be a difference, I'd add tests, but here they would be just outright redundant.

You've added eight or so new error conditions and only one of them is currently covered.

I'm asking about [42] = ... specifically because it's something the list() implementation would not necessarily check for (as it already had parser level checks for that).

Okay, added list_008.phpt

Another case of interest may be [&$a] = ...

Oh, yeah, list() still doesn't support assignment by-reference. I'd wanted to fix that.

mindplay-dk · May 8, 2016

Just wondering, have you thought of this weird edge case?

$a = "a";
$b = "b";

[$foo, $bar] = [$baz, $bat] = [$a, $b];

It's pretty ambigious - kind of hard to even assess what that means or what that would do.

I don't know if there's a real use case where this would ever matter - I just thought of it so figured I'd bring it up in case there's a missing edge test-case or something.

TazeTSchnitzel · May 8, 2016

Behaves the same as with list($foo, $bar) = list($baz, $bat) = [$a, $b];

mindplay-dk · May 8, 2016

Well, good, but a test-case to prove that fact probably wouldn't hurt? :-)

laruence · May 28, 2016

can this be closed? @bwoebi

nikic · May 28, 2016

Yes, it has already been merged.

bwoebi Allow for [] = $array; (alias for list())

6e73c03

nikic closed this May 28, 2016

@@ -5,6 +5,8 @@
      list($a, list($b)) = array(new stdclass, array(new stdclass));
      var_dump($a, $b);
+    +[$a, [$b]] = array(new stdclass, array(new stdclass));
+    +var_dump($a, $b);

php/php-src

[RFC] Short list syntax #1849

Reviewers

Assignees

Labels

Projects

Milestone

5 participants