Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
AO3-5110 Rails BOT: Don't try to autoload observers that no longer exist #3005
Conversation
sarken
added
Awaiting review
Priority: Broken on Test (High)
labels
Aug 24, 2017
|
I found a lingering code comment that refers to an observer--I'll correct that in this pull request, too, but I need to sleep first. |
elzj
merged commit b6c07b1
into
otwcode:master
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sarken commentedAug 24, 2017
Issue
https://otwarchive.atlassian.net/browse/AO3-5110
Purpose
In Rails 5.0 (#2958), we moved some code out of observers and into the models they actually pertain to, but our application.rb config was still trying to autoload these observers.
Testing
None beyond the regression test