AO3-4567 Minor fixes for ruby upgrades #2449
3 participants
zz9pzza
added
some commits
May 8, 2016
houndci-bot
commented on an outdated diff
lib/html_cleaner.rb
| @@ -184,8 +184,8 @@ def sanitize_value(field, value) | ||
| end | ||
| # grabbed from http://code.google.com/p/sanitizeparams/ and tweaked | ||
| - def sanitize_params(params = params) | ||
| - params = walk_hash(params) if params | ||
| + def sanitize_params(new_params = params) | ||
| + params = walk_hash(new_params) if new_params |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
|
sarken
commented on an outdated diff
app/controllers/devmode_controller.rb
| @@ -408,7 +408,6 @@ def create_work(name, authors, ratings, warnings, characters, relationships, fan | ||
| :authors => authors, | ||
| :summary => summary, | ||
| :fandoms => fandoms, | ||
| - :ratings => ratings, |
|
Just for nitpicking's sake, I'd actually leave this one and remove the one on line 419 instead -- this one is more logically placed (it's with the other tag types).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
|
Looks good to me barring sarken's note
zz9pzza
added
some commits
May 24, 2016
zz9pzza
added Coder has actioned review and removed Reviewed: Needs Coder Action labels 2 checks passed
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
hound
No violations found. Woof!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://otwarchive.atlassian.net/browse/AO3-4567
These are minor fixes pointed out by the ruby upgrades