/react

#8021 Fix gulp tasks: eslint and flow error on Windows #8241

Merged
merged 1 commit into from Nov 9, 2016
+2 −4

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed GH Review: accepted

Projects

None yet

Milestone

No milestone

3 participants

@jddxf @gaearon @facebook-github-bot
@jddxf
Contributor
jddxf commented Nov 9, 2016

No description provided.

@jddxf jddxf #8021 
Fix gulp tasks: eslint and flow error on Windows

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 88.719%
Details
8d03339
@gaearon
Member
gaearon commented Nov 9, 2016

I don't fully understand why this works but lgtm.
@gaearon gaearon merged commit 8267e11 into facebook:master Nov 9, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.719%
Details
@jddxf jddxf deleted the jddxf:gulp-eslint-and-flow-tasks-error-on-windows-fix branch Nov 10, 2016
@jddxf
Contributor
jddxf commented Nov 10, 2016

On Windows, node path_to_batch_file causes error while path_to_batch_file just works, since Node can interpret JavaScript code only and a batch file isn't written in JavaScript.
On Unix-like OSs, however, both node path_to_shell_script and path_to_shell_script work if the shell script is written in JavaScript. This is possible due to the shebang.
That's why the previous code works on Unix-like OSs only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment