LGTM - please do a test VSO build to confirm it works as expected for building/publishing packages.

@gkhanna79 setting that up now

LGTM

VSO builds look good.

For consistency can we do this exactly like corefx?
https://github.com/dotnet/corefx/blob/master/build-packages.cmd
https://github.com/dotnet/corefx/blob/master/build-packages.sh
https://github.com/dotnet/corefx/blob/master/config.json#L360

@Priya91 is there any reason we can't do this (e.g. where do arch/configuration come from)?

(e.g. where do arch/configuration come from)?

These are specified by the user to the scripts.

@weshaggard Are you implying to change build-packages to packages alias under build command? We can do that. Although we can't move specifying -Project alias to config.json, because coreclr expects absolute paths (I caused build breaks in partner teams and arm64 builds when using relative paths), and we haven't figured out how we can use other property values in config.json. For ex, in config.json,

"Project" : "{__ProjectDir <get value of this property here>}\<path-to-project>"

@Priya91 I'm ok if we have a command where we specify the project (packages.builds) in the scripts if we cannot correctly configure that in the config.json file. However my biggest thing is to remove as much of the logic from the scripts as possible and let msbuild do most of the heavy lifting.

@wtgodbe where do we stand on this one?

@danmosemsft huh, I thought I had already merged this. I think we should be fine to merge it now.

@dotnet-bot test this please

@wtgodbe go ahead ;)