/coreclr

Create CONTRIBUTING.md #6386

Merged
merged 1 commit into from Jul 22, 2016
+7 −0

Reviewers

No reviews

Assignees

No one assigned

Labels

cla-already-signed

Projects

None yet

Milestone

No milestone

3 participants

@richlander @adityamandaleeka @dnfclas
@richlander
Member
richlander commented Jul 21, 2016

This file exists in corefx and is an obvious file to look for. Making the two repos the same.
@richlander richlander Create CONTRIBUTING.md 
This file exists in corefx and is an obvious file to look for. Making the two repos the same.

Some checks were not successful

1 failing and 9 successful checks
Windows_NT x64 Release Priority 1 Build and Test — Build finished.
Details
CentOS7.1 x64 Debug Build and Test — Build finished.
Details
FreeBSD x64 Checked Build — Build finished.
Details
Linux ARM Emulator Cross Debug Build — Build finished.
Details
Linux ARM Emulator Cross Release Build — Build finished.
Details
OSX x64 Checked Build and Test — Build finished.
Details
Ubuntu x64 Checked Build and Test — Build finished.
Details
Windows_NT x64 Debug Build and Test — Build finished.
Details
Windows_NT x86 legacy_backend Checked Build and Test — Build finished.
Details
Windows_NT x86 ryujit Checked Build and Test — Build finished.
Details
2ffc8ad
@adityamandaleeka
Member
adityamandaleeka commented Jul 21, 2016

LGTM. In the future, please create a branch in your own fork instead of on the main repo when sending a PR, so that everyone who's pulling from the repo doesn't get your branch.
@adityamandaleeka
Member
adityamandaleeka commented Jul 21, 2016

I've opened an issue for the Windows test failure: #6397

Feel free to ignore it; I'm going to assume this change didn't break threading. 😄
@richlander
Member
richlander commented Jul 22, 2016

Fair enough on the additional branch. I have my own fork. I'll use it.
@richlander richlander merged commit 519d7d6 into master Jul 22, 2016
9 of 10 checks passed

9 of 10 checks passed

Windows_NT x64 Release Priority 1 Build and Test Build finished.
Details
CentOS7.1 x64 Debug Build and Test Build finished.
Details
FreeBSD x64 Checked Build Build finished.
Details
Linux ARM Emulator Cross Debug Build Build finished.
Details
Linux ARM Emulator Cross Release Build Build finished.
Details
OSX x64 Checked Build and Test Build finished.
Details
Ubuntu x64 Checked Build and Test Build finished.
Details
Windows_NT x64 Debug Build and Test Build finished.
Details
Windows_NT x86 legacy_backend Checked Build and Test Build finished.
Details
Windows_NT x86 ryujit Checked Build and Test Build finished.
Details
@richlander richlander deleted the richlander-patch-1 branch Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment