Start using CODE_OWNERS.TXT #5027

Merged
merged 1 commit into from May 17, 2016

Projects

None yet

5 participants

@noahfalk
Member

Our current approach to get eyeballs on issues relies on generous developers frequently triaging all issues. While convenient sometimes issues fall through the cracks. Providing a directory of maintainers allows contributors to take control and more quickly seek out the right maintainers to collaborate with.

@noahfalk noahfalk Start using CODE_OWNERS.TXT
3492de5
@noahfalk
Member

@jkotas - Jan I nominated you as the fallback person who will help issue filers locate maintainers if they aren't currently listed. Is that OK or is there a better nominee?

@noahfalk
Member

@richlander @mikem8361 @kspawa - fyi, you guys are all mentioned in the proposed CODE_OWNERS.TXT

@jkotas
Member
jkotas commented May 17, 2016

@jkotas - Jan I nominated you as the fallback person who will help issue filers locate maintainers

Sounds good.

@jkotas jkotas merged commit 1d80088 into dotnet:master May 17, 2016

1 of 8 checks passed

CentOS7.1 x64 Debug Build and Test Build finished.
Details
Ubuntu x64 Checked Build and Test Build finished.
Details
Windows_NT x64 Debug Build and Test Build finished.
Details
Windows_NT x64 Release Priority 1 Build and Test Build finished.
Details
Windows_NT x86 legacy_backend Checked Build and Test Build finished.
Details
Windows_NT x86 ryujit Checked Build and Test Build finished.
Details
OSX x64 Checked Build and Test Build started sha1 is merged.
Details
FreeBSD x64 Checked Build Build finished.
Details
@jkotas
Member
jkotas commented May 17, 2016

cc @dotnet/jit-contrib It may be useful to add RyuJIT maintainers to this file as well.

@jkotas
Member
jkotas commented May 17, 2016

@myungjoo It may be useful to add you or somebody from your team as Linux ARM port maintainer.

@myungjoo
Contributor

@jkotas You may include me.

Are we going to make it a rule that there will be one person per topic? or are we going to allow multiple co-maintainers on a topic? (as a secondary or emergency contact. we often do so in linux-kernel's MAINTAINERS entry)

@jkotas
Member
jkotas commented May 18, 2016

I do not think it needs to be one person per topic.

@noahfalk
Member

I did notice there is a line in there about sorting the list by last name (I copied the template from another repo). If we have more than one person it is likely to make it impossible to sort, but the last name sort doesn't seem very useful IMO. Presumably contributors will be reading this file because they don't know the name of the person they are looking for.

@lucenticus lucenticus added a commit to lucenticus/coreclr that referenced this pull request Jun 3, 2016
@noahfalk @lucenticus noahfalk + lucenticus Start using CODE_OWNERS.TXT (#5027) 48acfab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment