/coreclr

Permalink
Browse files

Handle mscorwks_unixexports.src with better regexp operator for compa… 

…tibility

ver3:
According to the gawk manual, The '\S' operator (as shorthand for '[^[:space:]]')
matches any character that is not whitespace. However, '[ \t]' is better than
'\S' for Mac OSX.
(source - https://www.gnu.org/software/gawk/manual/html_node/GNU-Regexp-Operators.html )

ver2:
With ver1, the build-break is caused by different awk versions (by @jkotas).
(Revert PR - #4005)
To resolve the limitation of the ver1, @janvorli proposed that the
\S expression is better than [:space:] for the most compatible solution.

There are a lot of different AWK software (e.g. awk, gawk, mawk, nawk, etc)
and versions among the popular Linux distributions. This patch is a simply
way to handle 'mscorwks_unixexports.src' file with \S operator for more
compatibility amon the different awk versions.

ver1:
It's must be modified by gawk implementation that check it exactly
as a plain character (e.g., space, alnum) within the bracket expression
at ./coreclr/generateversionscript.awk. The [[:space:]] is more appropriate than
the [:space:]]. (PR - #3943)

Signed-off-by: Geunsik Lim <[email protected]>
Signed-off-by: MyungJoo Ham <[email protected]>
Signed-off-by: Prajwal A N <[email protected]>
  • Loading branch information...
1 parent d3502c2 commit 6d7701c198590f8d727f038e1ba40b1e57c95ef6 @leemgs leemgs committed Apr 4, 2016
Unified Split
Showing with 1 addition and 1 deletion.
  1. +1 −1 generateversionscript.awk
View
2 generateversionscript.awk
@@ -8,7 +8,7 @@ BEGIN {
gsub(/\r/,"", $0);
# Skip empty lines and comment lines starting with semicolon
- if (NF && !match($0, /^[:space:]*;/))
+ if (NF && !match($0, /^[ \t]*;/))
{
print " " $0 ";";
}

0 comments on commit 6d7701c

Please sign in to comment.