Change to build to use dotnet #571

Closed
victorhurdugaci opened this Issue Jan 11, 2016 · 5 comments

Projects

None yet

5 participants

@victorhurdugaci

Kestrel has a "special" build:

  • It invokes DNX as a post build step
  • It relies on compilation modules
  • Might (not sure) spin up a new server that's not in proc as part of the tests

cc @cesarbs @halter73

@victorhurdugaci victorhurdugaci added this to the 1.0.0-rc2 milestone Jan 11, 2016
@victorhurdugaci

At a minimum, you have to upgrade a few scripts and project.json files just like here: aspnet/Configuration@9cfd22f

@cesarbs cesarbs was assigned by muratg Jan 11, 2016
@victorhurdugaci victorhurdugaci referenced this issue in aspnet/Universe Jan 11, 2016
Closed

Add support for dotnet CLI #324

71 of 71 tasks complete
@halter73
aspnet member
  • It invokes DNX as a post build step

I don't think this should be a huge issue. Basically all we need to do is run two command line apps (tools/Microsoft.AspNet.Server.Kestrel.GeneratedCode and tools/Microsoft.AspNet.Server.Kestrel.GeneratedCode) before building the main project.

  • It relies on compilation modules

I think we can remove this for now as long as we have a plan to move this to an analyzer.

  • Might (not sure) spin up a new server that's not in proc as part of the tests

Why do you think that? I'm pretty sure that's not the case.

@cesarbs
aspnet member

I think we can remove this for now as long as we have a plan to move this to an analyzer.

Why do we care about this only in Kestrel? I don't see anything similar in other projects.

@davidfowl
aspnet member

We don't actually. We can remove it for now and fix it later. @lodejard wrote it to keep himself in check 😄

@cesarbs cesarbs added 2 - Working and removed 1 - Ready labels Jan 12, 2016
@cesarbs cesarbs added a commit that referenced this issue Feb 1, 2016
@cesarbs cesarbs Build with dotnet (#571). 6757a31
@cesarbs cesarbs added 3 - Done and removed 2 - Working labels Feb 2, 2016
@cesarbs cesarbs closed this Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment