/wp-calypso

Build: Move react-dom and redux-thunk into vendor, drop debug #9146

Merged
merged 1 commit into from Nov 7, 2016

Reviewers

No reviews

Assignees

No one assigned

Labels

Build Framework

Projects

None yet

Milestone

No milestone

3 participants

@blowery @matticbot @gwwar
@blowery
Contributor
blowery commented Nov 4, 2016

Drop debug becauase we no-op it for production and if it's in vendor, the no-op doesn't really take.

No functional changes here
@blowery blowery Build: Move react-dom and redux-thunk into vendor, drop debug 
Drop debug becauase we no-op it for production and if it's in vendor, the no-op doesn't really take.

No functional changes here
This commit was signed with a verified signature.
@blowery blowery Ben Lowery
GPG key ID: 782AFA5641D62F5B Learn about signing commits
4c32553
@matticbot
matticbot commented Nov 4, 2016

Test live: https://calypso.live/?branch=update/build/vendor
@blowery
Contributor
blowery commented Nov 4, 2016

cc @gwwar @aduth
@gwwar
Member
gwwar commented Nov 4, 2016

Any bundle size differences to look for?
@blowery
Contributor
blowery commented Nov 4, 2016

should just be horse trading from build-production to vendor.
@gwwar
Member
gwwar commented Nov 4, 2016

👍 tests fine on local, docker, and desktop
@blowery
Contributor
blowery commented Nov 5, 2016 • edited

old sizes

vendor.production.js  1.19 MB (727K minified)
build-production.e6e223aa937832bffdf3.js  4.25 MB (2.5M minified)

new sizes:

vendor.production.js  1.76 MB (1.0M minified)
build-production.76e556718fdaed9100b8.js  3.67 MB (2.2M minified)
@blowery
Contributor
blowery commented Nov 6, 2016

Hrm, I didn't expect a 300kb move... react-dom and redux-thunk are both tiny.
@blowery
Contributor
blowery commented Nov 6, 2016

ahhhh. sneaky. react-dom just requires react/lib/ReactDOM which then pulls in the planet.
@blowery blowery merged commit 8034594 into master Nov 7, 2016
1 check passed

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@blowery blowery deleted the update/build/vendor branch Nov 7, 2016
@bisko bisko added a commit that referenced this pull request Nov 16, 2016
@blowery @bisko blowery + bisko Build: Move react-dom and redux-thunk into vendor, drop debug (#9146) 
Drop debug becauase we no-op it for production and if it's in vendor, the no-op doesn't really take.

No functional changes here
 e13cb5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment