Browse files

button.js: Set disabled property in addition to disabled attribute to…

… preserve behavior under jQuery 3 (#20278)

This code ought to have used .prop instead of .attr in the first place,
but we can't get rid of the attr manipulation now due to backward compatibility constraints.

Refs https://github.com/jquery/jquery-migrate/blob/3.0.0/warnings.md#jqmigrate-jqueryfnremoveattr-no-longer-sets-boolean-properties
Refs #16834

[skip validator]
  • Loading branch information...
1 parent 1956146 commit e67e3e9b19bde8161526e835c43f2e1b23368499 @cvrebert cvrebert committed on GitHub Jul 12, 2016
Showing with 2 additions and 2 deletions.
  1. +2 −2 js/button.js
View
4 js/button.js
@@ -41,10 +41,10 @@
if (state == 'loadingText') {
this.isLoading = true
- $el.addClass(d).attr(d, d)
+ $el.addClass(d).attr(d, d).prop(d, true)
} else if (this.isLoading) {
this.isLoading = false
- $el.removeClass(d).removeAttr(d)
+ $el.removeClass(d).removeAttr(d).prop(d, false)
}
}, this), 0)
}

0 comments on commit e67e3e9

Please sign in to comment.