Correctly handle multi-values when converting VCards to array #1190

Merged
merged 2 commits into from Aug 30, 2016

5 participants

@nickvergessen
Nextcloud member

This affects "only" the php API of our implementation, not related to sync or whatever.

Steps

  1. Create a contact named "Hello Testing" (with the contacts app)
  2. Add 2 cloud ids: [email protected], [email protected]
  3. Open the share dropdown in the files view and type admin@ into the box

Expected

Two results for federated sharing:

  • Hello Testing (at nextcloud.com)
  • Hello Testing (at example.tld)

Actual

Only one result for federated sharing (the second cloud id you entered):

  • Hello Testing (at example.tld)

@karlitschek requesting backport to 10 and 9, since this is quite heavy. The same happens for emails and addresses (used by calendar) and it also makes the activity app not finding matches when it's not the first cloud id.

@rullzer @MorrisJobke

nickvergessen added some commits Aug 30, 2016
@nickvergessen nickvergessen Correctly handle multi-values when converting VCards to array 0c4d471
@nickvergessen nickvergessen Add a unit test for all the magic
a123fe6
@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Aug 30, 2016
@mention-bot

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @georgehrke and @DeepDiver1975 to be potential reviewers

@karlitschek
Nextcloud member

great. backport makes sense 👍

@rullzer
Nextcloud member

Nice 👍

@MorrisJobke
Nextcloud member

Tested and works 👍

@MorrisJobke MorrisJobke merged commit c54d6d0 into master Aug 30, 2016

3 of 4 checks passed

Details Scrutinizer Created
approvals/lgtm this commit looks good
Details continuous-integration/drone the build was successful
Details continuous-integration/travis-ci/pr The Travis CI build passed
@MorrisJobke MorrisJobke deleted the addressbook-correctly-handle-multi-values branch Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment