/server

Prevent parse error on editing an HTML comment #1132

Merged
merged 1 commit into from Aug 29, 2016
+1 −1

Labels

3. to review bug feature: comments

Milestone

  Nextcloud 11.0

Assignees

No one assigned

5 participants

@nickvergessen @mention-bot @LukasReschke @blizzz @MorrisJobke
@nickvergessen
Nextcloud member
nickvergessen commented Aug 29, 2016

Steps

  1. Post comment " style="border: 1px solid blue;
  2. Click on "Edit comment" pencil
  3. Enjoy the blue border on your empty input

@LukasReschke as discussed
@rullzer @blizzz please review

I will create the backports

@nickvergessen nickvergessen Prevent parse error on editing an HTML comment
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits

All checks have passed

4 successful checks
Details
Scrutinizer — No new issues
approvals/lgtm — this commit looks good
Details
continuous-integration/drone — the build was successful
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
28792a0
@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Aug 29, 2016
@mention-bot
mention-bot commented Aug 29, 2016

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @jancborchardt and @vincchan to be potential reviewers

This was referenced Aug 29, 2016
Merged
Merged
@nickvergessen nickvergessen referenced this pull request in nextcloud/announcementcenter Aug 29, 2016
Merged

Prevent parse error on editing an HTML comment #34

@nickvergessen
Nextcloud member
nickvergessen commented Aug 29, 2016

Please while in rampage, also review the very same fix in the announcements app:
nextcloud/announcementcenter#34 + backport nextcloud/announcementcenter#35

@LukasReschke
Nextcloud member
LukasReschke commented Aug 29, 2016

LGTM

@blizzz
Nextcloud member
blizzz commented Aug 29, 2016

LGTM

@blizzz blizzz merged commit 7278bd2 into master Aug 29, 2016
4 checks passed

4 checks passed

Details Scrutinizer No new issues
approvals/lgtm this commit looks good
Details continuous-integration/drone the build was successful
Details continuous-integration/travis-ci/pr The Travis CI build passed
@blizzz blizzz deleted the prevent-parse-error-on-editing-an-html-comment branch Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment