Check if the file isReadable() before sending a (cached) preview #1089
if you want to limit permissions with a storage wrapper you'll have to modify the cache results (or just use PermissionsMask which already does everything for you)
Well then what is the use case of these methods, if they do not what they suggest they do?
Node API uses those methods, but the storage never said if it is okay?!
Infact the storage is so far never contacted. Also I would not know how I can controll the permissions in the file cache, I can't store something in there, since it depends on too many things.
Infact the storage is so far never contacted
Which is exactly what it should be doing
Also I would not know how I can controll the permissions in the file cache
Use the storage wrapper to wrap the cache instance and modify the returned objects (again use the PermissionsMask wrapper)
@icewind1991 like this? See this PR and https://github.com/nextcloud/files_accesscontrol/pull/31/files
Second review please @MorrisJobke @rullzer also for the apps PR https://github.com/nextcloud/files_accesscontrol/pull/31/files
This is required for the access controls, so the storage wrapper can deny the displaying and generation of previews: nextcloud/files_accesscontrol#30
Also fixes the gallery with named issue.
@icewind1991 @LukasReschke