/server

Fix the syntax of the federation ID share buttons #1085

Merged
merged 3 commits into from Aug 26, 2016

Labels

4. to release bug design feature: federation

Milestone

  Nextcloud 11.0

Assignees

No one assigned

5 participants

@nickvergessen @mention-bot @LukasReschke @jancborchardt @rullzer
@nickvergessen
Nextcloud member
nickvergessen commented Aug 26, 2016

There is also another problem with the gnu button: div is not allowed inside p.

But I can't fix this.

@nickvergessen nickvergessen FIx the syntax of the buttons
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits

Some checks haven’t completed yet

1 pending and 3 successful checks
approvals/lgtm — this commit is pending approval
Details
Scrutinizer — 4 new issues, 1 updated code elements
Details
continuous-integration/drone — the build was successful
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
ab5a69b
@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Aug 26, 2016
@mention-bot
mention-bot commented Aug 26, 2016

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @jancborchardt and @LukasReschke to be potential reviewers

@nickvergessen nickvergessen Fix more HTML "syntax"
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits

All checks have passed

3 successful checks
Details
Scrutinizer — 4 new issues, 1 updated code elements
Details
continuous-integration/drone — the build was successful
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
419c42b
@nickvergessen nickvergessen changed the title from Fix the syntax of the buttons to Fix the syntax of the federation ID share buttons Aug 26, 2016
@nickvergessen nickvergessen Reorder the buttons by importance
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits

All checks have passed

4 successful checks
Details
Scrutinizer — 4 new issues, 1 updated code elements
approvals/lgtm — this commit looks good
Details
continuous-integration/drone — the build was successful
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
6b885bb
@LukasReschke
Nextcloud member
LukasReschke commented Aug 26, 2016

LGTM

@LukasReschke
Nextcloud member
LukasReschke commented Aug 26, 2016

cc @ChristophWurst @jancborchardt Please review.

@jancborchardt
Nextcloud member
jancborchardt commented Aug 26, 2016

Yeah, good reordering 👍

@rullzer rullzer merged commit c20aef8 into master Aug 26, 2016
4 checks passed

4 checks passed

Details Scrutinizer 4 new issues, 1 updated code elements
approvals/lgtm this commit looks good
Details continuous-integration/drone the build was successful
Details continuous-integration/travis-ci/pr The Travis CI build passed
@rullzer rullzer deleted the fix-ffs-sharing-syntax branch Aug 26, 2016
@nickvergessen
Nextcloud member
nickvergessen commented Aug 26, 2016

Should backport the syntax fix to 10, the reordering as well? @jancborchardt

@jancborchardt
Nextcloud member
jancborchardt commented Aug 26, 2016

Nah, just backport the fix there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment