Allow automatic DI for the View #1038

Closed
wants to merge 1 commit into
from

5 participants

@nickvergessen nickvergessen Allow automatic DI for the View
908dba9
@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Aug 24, 2016
@mention-bot

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @BernhardPosselt, @DeepDiver1975 and @rullzer to be potential reviewers

@rullzer
Nextcloud member

I still think we should use the Node API more. But admittedly this is not possible everywhere.

I had the discussion a bit with @BernhardPosselt where we do the DI of private classes. Still need to think about that a bit more and write it down somewhere.

@nickvergessen
Nextcloud member

Well people use the view today, this here is just a matter of automating it...

@rullzer
Nextcloud member

Yeah but it is also currently working. Adding this kind of legitimises the use of the view for Apps. Which is not really true. Apps should only use stuff from OCP

@LukasReschke
Nextcloud member

I do second @rullzer

@rullzer rullzer deleted the allow-automatic-DI-for-view branch Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment