Allow automatic DI for the View #1038
+4
−0
mention-bot
commented
Aug 24, 2016
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @BernhardPosselt, @DeepDiver1975 and @rullzer to be potential reviewers
I still think we should use the Node API more. But admittedly this is not possible everywhere.
I had the discussion a bit with @BernhardPosselt where we do the DI of private classes. Still need to think about that a bit more and write it down somewhere.
Yeah but it is also currently working. Adding this kind of legitimises the use of the view for Apps. Which is not really true. Apps should only use stuff from OCP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@LukasReschke @BernhardPosselt